Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #4459/06675034 backport][stable-4] dnsmadeeasy: only get monitor if it is not null api response #4500

Merged
merged 1 commit into from
Apr 13, 2022
Merged

[PR #4459/06675034 backport][stable-4] dnsmadeeasy: only get monitor if it is not null api response #4500

merged 1 commit into from
Apr 13, 2022

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Apr 13, 2022

This is a backport of PR #4459 as merged into main (0667503).

SUMMARY

dnsmadeeasy module, fails if "monitor" key is null in the api response, this change adds a check

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

net_tools/dnsmadeeasy

ADDITIONAL INFORMATION

it adds a check for "monitor" value in api response partially fixes #3620, delete should work, updates are not perfect

@drevai753 @patchback
dnsmadeeasy: only get monitor if it is not null api response (#4459)
bd69691 
* Only get monitor if it is not null api response

* Add changelog fragment

* Update changelogs/fragments/4459-only-get-monitor-if-it-is-not-null-api-response.yaml

Co-authored-by: Felix Fontein <[email protected]>

* Update plugins/modules/net_tools/dnsmadeeasy.py

Co-authored-by: Felix Fontein <[email protected]>

Co-authored-by: drevai <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 0667503)
@patchback patchback bot mentioned this pull request Apr 13, 2022
Merged
@ansibullbot
Copy link
Collaborator

cc @briceburg
click here for bot help

@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug module module net_tools new_contributor Help guide this first time contributor plugins plugin (any type) labels Apr 13, 2022
@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #4500 (0667503) into stable-4 (d53052f) will increase coverage by 1.09%.
The diff coverage is 0.00%.

❗ Current head 0667503 differs from pull request most recent head bd69691. Consider uploading reports for the commit bd69691 to get more accurate results

@@             Coverage Diff              @@
##           stable-4    #4500      +/-   ##
============================================
+ Coverage     43.56%   44.66%   +1.09%     
============================================
  Files           926      951      +25     
  Lines         90108    93519    +3411     
  Branches      16522    17142     +620     
============================================
+ Hits          39259    41767    +2508     
- Misses        49103    49842     +739     
- Partials       1746     1910     +164
Flag Coverage Δ
integration 70.84% <ø> (-1.13%) ⬇️
sanity 21.26% <ø> (-0.10%) ⬇️
stub 0.00% <0.00%> (ø)
units 67.45% <ø> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.azure-pipelines/scripts/publish-codecov.py 0.00% <0.00%> (ø)
plugins/modules/packaging/os/pkgng.py 41.84% <0.00%> (-42.26%) ⬇️
plugins/module_utils/mh/deco.py 67.74% <0.00%> (-26.86%) ⬇️
...ugins/modules/remote_management/ipmi/ipmi_power.py 26.02% <0.00%> (-17.57%) ⬇️
plugins/callback/syslog_json.py 43.39% <0.00%> (-14.11%) ⬇️
plugins/inventory/linode.py 35.71% <0.00%> (-11.41%) ⬇️
plugins/module_utils/proxmox.py 44.30% <0.00%> (-10.46%) ⬇️
plugins/filter/list.py 86.88% <0.00%> (-9.12%) ⬇️
...les/source_control/gitlab/gitlab_group_variable.py 18.78% <0.00%> (-8.65%) ⬇️
plugins/lookup/dsv.py 71.79% <0.00%> (-8.21%) ⬇️
... and 171 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f3a7a9...bd69691. Read the comment docs.

@felixfontein felixfontein merged commit 70a3dae into stable-4 Apr 13, 2022
@felixfontein felixfontein deleted the patchback/backports/stable-4/06675034fef477562db69277203805008e2979f8/pr-4459 branch April 13, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug module module net_tools new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ansibullbot @felixfontein @drevai753